PhotoPlog

Go Back   PhotoPlog > PhotoPlog Lite > Bugs & Issues Tracker
Screens Demo Purchase Download Register

Reply
Attention: Last reply in this thread was more than 11 Years ago
 
Thread Tools
  #1  
Old 01-22-2006, 11:30 PM
Nitro Nitro is offline
Yellow Plog
 
Join Date: Dec 2005
Posts: 63
Gallery: 0
Comments: 0
Default [Closed via Lite v.1.0.7] Duplicate dirs bug in breadcrumb

Being one of the first to suffer duplicate dirs I cant believe I'v only just found this but on photoplog pages the breadcrumb icon to refresh/reload the current page still has duplicate directories. "/portal/forums/portal/photoplog/index.php"

It should be removing the /portal/forums from it and then it would be fine.

It also may well be usefull to know how you fix it as it may help me go back to being able to use relative links elsewhere from other products that appear on photoplog pages.
Reply With Quote
  #2  
Old 01-24-2006, 10:01 AM
Morgan's Avatar
Morgan Morgan is offline
Head Plog
Admin
 
Join Date: Dec 2005
Posts: 5,324
Gallery: 10
Comments: 25
Default

Do these match with what you have for your site?
Code:
Content visible to registered users only.
In the default navbar template there are three links:
Code:
Content visible to registered users only.
What do they look like in your navbar template?

Also what does the HTML source look like for these three links?

In general there are basically three ways to handle relative links. One is to do like PhotoPlog does and automatically make absolute links. Two is to provide text boxes where the user lists what and where to link. Three is a combination of one and two, but none is truly ideal for all directory structures, skins, sub-domains, etcetera.
__________________
Please use the forums for support, feature requests, and similar such things. Support does not include custom code, custom template edits, or third-party modifications. PMs and emails to me should be for private information only, such as login information. If you PM or email me a support question, chances are good that I'll ignore it. Thanks.
While the work or play is on, it is a lot of fun if while you are doing one you don't constantly feel that you ought to be doing the other. -- Franklin Pierce Adams
Reply With Quote
  #3  
Old 01-24-2006, 06:51 PM
Nitro Nitro is offline
Yellow Plog
 
Join Date: Dec 2005
Posts: 63
Gallery: 0
Comments: 0
Default

Checked these and removed /portal from the vb Home url setting

I cant see anywhere to put Photoplog URL ?

That navbar section looks identical.
Reply With Quote
  #4  
Old 01-25-2006, 11:10 AM
Morgan's Avatar
Morgan Morgan is offline
Head Plog
Admin
 
Join Date: Dec 2005
Posts: 5,324
Gallery: 10
Comments: 25
Default

You can keep /portal in Home URL if that's how you want it, I was wondering the values of your settings is all. The PhotoPlog URL isn't a setting though, it's just the link to PhotoPlog on your site.

The 'Reload this Page' breadcrumb link is coming out like that because $scriptpath is returning /portal/photoplog/index.php and then PhotoPlog sees it's a relative link and prepends http://www.domain.com/portal/forums to form the link you see.

The duplicate directory, while thought of as the part to take off the end of the Forum URL, really comes off the beginning of relative links in the HTML source of a page.

In the photoplog_output_error and photoplog_output_page functions, right after all the global bits, add the following:
Code:
Content visible to registered users only.
__________________
Please use the forums for support, feature requests, and similar such things. Support does not include custom code, custom template edits, or third-party modifications. PMs and emails to me should be for private information only, such as login information. If you PM or email me a support question, chances are good that I'll ignore it. Thanks.
While the work or play is on, it is a lot of fun if while you are doing one you don't constantly feel that you ought to be doing the other. -- Franklin Pierce Adams
Reply With Quote
  #5  
Old 01-25-2006, 12:39 PM
Nitro Nitro is offline
Yellow Plog
 
Join Date: Dec 2005
Posts: 63
Gallery: 0
Comments: 0
Default

That code seems to have done the trick

My link to photoplog is absolute and added to my portals side menu block as are most, but theres a few default links using similar globals I am wondering if i could fix these in a similar way. I will give them a go later as the sidemenu block has relative links using variables to the portalhome forumhome and one or to others inside conditionals. Theres other blocks that also link to various sections of both portal and forums that I cant add to the left column casue of the issue. If it fixes the few variables in the portals side menu block i may have to write up a huge list for the other block types.

I am thinking if thats whats nesseacry it would probably better making a seperate file for it all and using a require call at those points instead ?
Reply With Quote
  #6  
Old 01-25-2006, 12:52 PM
Morgan's Avatar
Morgan Morgan is offline
Head Plog
Admin
 
Join Date: Dec 2005
Posts: 5,324
Gallery: 10
Comments: 25
Default

Do these portal blocks have some sort of underlying commonality? Perhaps there's a variable unique to the portal that gets set and is used in each block?
__________________
Please use the forums for support, feature requests, and similar such things. Support does not include custom code, custom template edits, or third-party modifications. PMs and emails to me should be for private information only, such as login information. If you PM or email me a support question, chances are good that I'll ignore it. Thanks.
While the work or play is on, it is a lot of fun if while you are doing one you don't constantly feel that you ought to be doing the other. -- Franklin Pierce Adams
Reply With Quote
  #7  
Old 01-25-2006, 07:59 PM
Nitro Nitro is offline
Yellow Plog
 
Join Date: Dec 2005
Posts: 63
Gallery: 0
Comments: 0
Default

Yes I suspect so on the whole Im just not sure how I need to apply it. I have tried for a while today with no success so far :/

I was hoping something like this would do
Code:
Content visible to registered users only.
on a link thats like this in the navbar template to the portal home and I am quite sure one or two of these would cover the vast majority.

Code:
Content visible to registered users only.
and another link which I am sure is using quite a common relative var in the vbportal, probably more common than the above.
Code:
Content visible to registered users only.
I will try some more later, to much lack of success makes me very tired and I start crashing out in my chair. I may have to ask a felllow vbportal person to take a quick look, I am sure the right syntax could be found in minutes not hours like it takes me sometimes.
Reply With Quote
  #8  
Old 01-26-2006, 12:16 AM
Morgan's Avatar
Morgan Morgan is offline
Head Plog
Admin
 
Join Date: Dec 2005
Posts: 5,324
Gallery: 10
Comments: 25
Default

In the PhotoPlog settings.php file find:
Code:
Content visible to registered users only.
And replace with the following:
Code:
Content visible to registered users only.
And then go set the PhotoPlog Duplicate Directory to empty.

What happens?
__________________
Please use the forums for support, feature requests, and similar such things. Support does not include custom code, custom template edits, or third-party modifications. PMs and emails to me should be for private information only, such as login information. If you PM or email me a support question, chances are good that I'll ignore it. Thanks.
While the work or play is on, it is a lot of fun if while you are doing one you don't constantly feel that you ought to be doing the other. -- Franklin Pierce Adams
Reply With Quote
  #9  
Old 01-27-2006, 11:34 PM
Nitro Nitro is offline
Yellow Plog
 
Join Date: Dec 2005
Posts: 63
Gallery: 0
Comments: 0
Default

I did this and I think after a breif whip round it is certainly far better, but not without some other problems, maybe these will be easier to fix tho. What it seems to do after commenting out the code from post #4 and doing this replace and removing the duplicate dir setting is:
CSS image paths now appear to be ok without the dupe dir setting.
All photoplog links appear to be ok
My portal side menu links the relative ones that are template coded seem fine too.
The final bread crumb link is also good.

What appeared to end up getting broken from it is the navbar links on any photoplog page ie usercp etc as by default these are relative to the forum directory (so possibly the footer links aswell). Yes in the navbar I can make them relative from the webroot instead which is one answer. However other galleries do not need it in similar layouts and I am not sure why.

The layout I use is.

/portal
/portal/forums
/portal/photoplog

The layouts I have done elsewhere with other galleries is not much different but often the portal is in the webroot not in a subdir.
What I will do over the weekend is apply the change on the live site where I know all styles in use are in much better shape than some of the same styles on the test install. I should have a final confirmation on how its panning out then and I think one of those styles uses replacements aswell.
Reply With Quote
  #10  
Old 01-28-2006, 03:50 PM
Nitro Nitro is offline
Yellow Plog
 
Join Date: Dec 2005
Posts: 63
Gallery: 0
Comments: 0
Default settings.php fix Applied to live site.

I think building on this is the way to go, from what I can see on my live install it has cured all duplicate directories without the need to have anything set for it in photoplog settings. Thats the good news because vbportal also has a module dropdown box in the menu block to save housing all links in a list, this is also now functioning as would be expected.

The bad news is (and I have been throught it relatively thoroughly in an untouched vb default style), is default links called in a relative to forum root related to going to forum pages appear to be broken, also the default styles css image paths and stylevar image paths are relative to forum root so they too are broken. The images are easy to fix in this instance by using a replacement variable. The links present a more awkward situation. One quite simple suggestion would be for photoplog to carry extra cp settings for forum path and forum url, ie $vbpotions->photoplog->[bbdir] and [bburl] and then carry its own header, navbar and footer. I think all relative referenced links and images not from the webroot can then be defined in a relative way using the extra variables in all photoplog templates. Theres probably a better way but I'm not a php expert.
I am sure I had to repair some links in a photopost install I did a few weeks back for someone for this very reason and had to make them relative to webroot with portal defined variables.

To summarise it should now be good for photoplog to have elements from other 3rd party scripts that dont sit in forum root either to use relative links and paths with their own variables and anything that this fix currently breaks in vb links and images can certainly be fixed in a relative way. Not so good for those who have a few dozen styles with a lot of individual customisations tho as the likelyness of the these 3 main templates being individual to each style is high, which is why I hope theres a way to build on the fix for those people.
Reply With Quote
Reply

« Previous Thread | Next Thread »
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[Closed via Lite v.1.0.7] A small bug in Photoplog Lite alpha Bugs & Issues Tracker 4 02-17-2006 02:24 AM


All times are GMT. The time now is 08:25 AM.


Powered by vBulletin® Version 3.8.5
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.